Release 0.2.0#4
Merged
Merged
Conversation
This includes various fixes for spawning Android emulators on Windows, including support for spawning an emulator within a dedicated job object so that it's possible to terminate `emulator.exe` and the qemu child process together.
Similar to how the emulator is run within a job object on Windows, this ensures we add the emulator to a dedicated process group on Linux / macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
EmulatorClient::shutdown()API to request the emulator to perform a graceful shutdown.Changes
Emulator::terminate()renamed toEmulator::kill()to avoid confusion with the gRPCTerminatestate that can be requested.Fixes