bootstrap: add bootstrap step to run intrinsic-test in CI#156356
Open
xonx4l wants to merge 13 commits into
Open
bootstrap: add bootstrap step to run intrinsic-test in CI#156356xonx4l wants to merge 13 commits into
xonx4l wants to merge 13 commits into
Conversation
rustbot
added
A-CI
Collaborator
|
|
rustbot
added
the
T-infra
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
folkertdev
reviewed
May 10, 2026
Comment on lines
+916
to
+918
| fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> { | ||
| run.path("library/stdarch/crates/intrinsic-test") | ||
| } |
Contributor
There was a problem hiding this comment.
the intrinsic tests should also run when any of the source in core_arch changes (unless I'm misinterpreting what this function does).
Contributor
Author
There was a problem hiding this comment.
No you are not misinterpreting :) . You're so right I have added the core_arch path so it triggers . Thanks for the review.
Comment on lines
+27
to
+30
| RUN curl -L http://ci-mirrors.rust-lang.org/sde-external-10.8.0-2026-03-15-lin.tar.xz -o /tmp/sde.tar.xz \ | ||
| && mkdir -p /intel-sde \ | ||
| && tar -xJf /tmp/sde.tar.xz --strip-components=1 -C /intel-sde \ | ||
| && rm /tmp/sde.tar.xz |
Contributor
There was a problem hiding this comment.
this doesn't need an instant fix, but we bump the version of this tool occasionally, so ideally we'd sync that version between the repositories.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports
library/stdarch/crates/intrinsic-testcrate into the bootstrap test runner as a step, so that we can run the intrinsic-test suite via x.py test.Changes -:
Ports
intrinsic-testfrom the stdarch crate into the bootstrap system as a new test step so it runs inside the existingx86_64-gnuandaarch64-gnuCI jobs .Added
intrinsic-testinsrc/bootstrap/src/core/build_steps/test.rs.Registers
intrinsic-testas a bootstrap tool intool.rs.Installs
clang,lld, and Intel SDE in the respective Dockerfiles.r? @Kobzol