more proc_macro bridge cleanups#151694
Merged
Merged
Conversation
Collaborator
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use |
ChayimFriedman2
approved these changes
Jan 26, 2026
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 27, 2026
…enkov more `proc_macro` bridge cleanups Some followups made possible by rust-lang#151505.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 27, 2026
…enkov more `proc_macro` bridge cleanups Some followups made possible by rust-lang#151505.
Contributor
|
Nice changes! |
nnethercote
reviewed
Jan 28, 2026
| } | ||
| } | ||
|
|
||
| // FIXME(eddyb) generate these impls by pattern-matching on the |
Contributor
There was a problem hiding this comment.
Two thumbs up for eliminating one of these FIXME comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some followups made possible by #151505.