Optimize swizzle_dyn for AArch64 with N > 16#528
Merged
Conversation
Member
|
to ensure it's actually tested, you'll need to uncomment the lane counts that you have special cases for, so uncomment 48 here: portable-simd/crates/test_helpers/src/lib.rs Line 681 in 94a3ba2 |
We can do swizzles for 24, 32, 48 and 64 byte vectors by stacking multiple TBL instructions. See https://godbolt.org/z/PE95nrqjj for a comparison of the generated assembly.
Kmeakin
force-pushed
the
km/aarch64-dyn-swizzle
branch
from
8278494 to
beafe83
Compare
programmerjake
approved these changes
May 30, 2026
Member
|
Looks good, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can do swizzles for 24, 32, 48 and 64 byte vectors by stacking multiple TBL instructions.
See https://godbolt.org/z/PE95nrqjj for a comparison of the generated assembly.
I would do the same optimization for 32-bit Arm but I can't get at the intrinsics for some reason: https://godbolt.org/z/54jqTEeeW