Change connected() to take &self instead of &mut self#1257
Open
cuishuang wants to merge 2 commits into
Open
Conversation
Signed-off-by: cuishuang <imcusg@gmail.com>
DanielEScherzer
approved these changes
May 17, 2026
Signed-off-by: cuishuang <imcusg@gmail.com>
Author
Thanks. I resubmitted the changes and modified the test cases to pass the CI |
Contributor
|
Is this safe even with a custom transport? The transport vtable does not seem to enforce this as const or have any comments or contracts around that. |
ehuss
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connected method only reads the connection status without mutating state, so &self is sufficient and avoids unnecessary mutable borrow.