split Tool and ToolFamily to a new tool module#929
Conversation
|
I'm ok with this changes, but I'm afraid of creating merge conflicts that's a bit hard to fix in other PRs. cc @thomcc what's your thought on this? |
|
This is just moving code from one file to another. Merge conflicts should be pretty easy to resolve. |
If someone modifies tool impl (e.g. #932 ) then it will have to rewrote it by moving changes into the new file. Wirh rhat said, if #932 is the only PR that will have a merge conflict, then I'm willing to merge this and resolve the conflict myself. |
|
Sorry, I forgot to hit enter. I was going to say:
But with your comment that it's a single conflicting PR, I think we should go for it. |
NobodyXu
left a comment
There was a problem hiding this comment.
Thanks, but you would need to resolve merge conflicts before I can merge it
|
Merge conflict fixed. |
No description provided.