Reimplemented glob stripping with regex#297
Open
egormanga wants to merge 1 commit into
Open
Conversation
Author
|
This is partially needed for correct building of the current master of ch32-rs. Will link its relevant PR here when ready. |
burrbull
reviewed
May 16, 2026
| fn strip_start(&mut self, prefix: &str) -> PatchResult { | ||
| let len = prefix.len(); | ||
| let glob = globset::Glob::new(&(prefix.to_string() + "*"))?.compile_matcher(); | ||
| let re = regex::Regex::new(&globset::Glob::new(prefix)?.regex().replace("(?-u)", "").replace("*", "*?").strip_suffix("$").unwrap())?; |
Member
There was a problem hiding this comment.
It is hard to read. Format this or better split it into two separate statements.
Member
Is it? I think #49 is about significant change of syntax. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, using strip patterns such as
REG[ABC]_results in panic due to bounds check, since the implementation naïvely treats them as fixed-lengthed. This logic was never correct.This reimplements the logic using proper regex conversion, similar to that in the legacy Python version, which allows to use more elaborate patterns.