types: fix getblockstats txs field doc#592
Open
satsfy wants to merge 1 commit into
Open
Conversation
The txs field counts all transactions in the block including the coinbase.
111605e to
01fc4f2
Compare
Collaborator
jamillambert
left a comment
There was a problem hiding this comment.
I checked the docs and it looks like this changed in v20, i.e. v17-19 say (excluding coinbase). I didn't check if it actually changed or the docs were fixed. I say this because I know of other cases where the docs in v17 or so were incorrect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs are wrong in getblockstats txs field. The txs field counts all transactions in the block including the coinbase. Core's source passes
block.vtx.size()directly, which includes the coinbase transaction at index 0. Bitcoin Core doc agrees.Example, I just called
Now I run
Returns 1 because that is the coinbase transaction.