Skip to content

Parses simple blocks after a block group are silently ignored. - #95

Draft
Matthias-Fauconneau wants to merge 3 commits into
rust-av:masterfrom
Matthias-Fauconneau:cluster
Draft

Parses simple blocks after a block group are silently ignored.#95
Matthias-Fauconneau wants to merge 3 commits into
rust-av:masterfrom
Matthias-Fauconneau:cluster

Conversation

@Matthias-Fauconneau

Copy link
Copy Markdown
Contributor

Simple blocks after a block group are silently ignored.
Parsing into the existing simple_block would reorder.
This parses all simple blocks into struct BlockGroup to allow any interleaving of simple blocks or block groups inside a cluster while preserving the order.
If that's an acceptable solution, the serialization needs to be updated.

@Luni-4

Luni-4 commented Mar 30, 2023

Copy link
Copy Markdown
Member

@Matthias-Fauconneau What's the status of this PR?

@Matthias-Fauconneau

Copy link
Copy Markdown
Contributor Author

I think that's the proper solution.
Deserialization works for me.
You might want to also do the serialisation part though.

@Luni-4

Luni-4 commented Mar 30, 2023

Copy link
Copy Markdown
Member

Could you please open an issue specifying what is left to do and close this PR? In this way I can remember what we need to implement :)

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants