Edition 2024 - #315
Draft
FreezyLemon wants to merge 18 commits into
Draft
Conversation
seems to be unused
both are semver-compatible if the std feature (default) is enabled
not for av_metrics_tests because it's publish = false anyways
most of these functions were only unsafe because they use AVX2 instructions. this is considered safe in Rust as long as the relevant #[target_feature] attribute is added to the containing function. this makes the migration easier
no further code changes necessary
FreezyLemon
marked this pull request as draft
July 6, 2026 19:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #311, #313 and #314 (and probably a rebase haha).
cargo fix --editionshows one nothingburger with the drop order change, so I reverted the code change. Rest was just macro stuff ($asdf:exprbecame$asdf:expr_2021, reverted too) and some placement of unsafe keywords. That's why I reordered some code in the CIEDE AVX2 module, and to reduceunsafein general.