Skip to content

feat(settings): implement public settings route and UI updates for issue#15#73

Open
Jayavardhanattaluri wants to merge 2 commits into
rushikesh-bobade:mainfrom
Jayavardhanattaluri:issue#15
Open

feat(settings): implement public settings route and UI updates for issue#15#73
Jayavardhanattaluri wants to merge 2 commits into
rushikesh-bobade:mainfrom
Jayavardhanattaluri:issue#15

Conversation

@Jayavardhanattaluri

Copy link
Copy Markdown

Description

This PR addresses Issue #15 by implementing the public settings route and updating the relevant user interface layout elements according to the project design guidelines.

Changes Made

  • Created the public settings route (app/routes/settings-public.tsx).
  • Updated global layout components (app/sidebar, navigation components) to integrate the new route seamlessly.
  • Adjusted localized component styles using existing design tokens.
  • Ensured all 20 affected files conform to the repository's formatting standards via Prettier.

Note for Reviewers

Local database validation via Prisma/Supabase was bypassed during testing due to isolated environment constraints, but all components are statically verified and properly typed.

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

@Jayavardhanattaluri is attempting to deploy a commit to the participationcorner2025-8967's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codesense Ai: This PR is too large to review automatically. A human maintainer will take a look!

@github-actions github-actions Bot added the ECSoC26 Required label for ECSOC Sentinel scoring label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codesense Ai: This PR is too large to review automatically. A human maintainer will take a look!

@rushikesh-bobade

Copy link
Copy Markdown
Owner

Hey @Jayavardhanattaluri!

Welcome to the project, and thank you for taking this on! The new UI for the avatar upload looks great, and your Supabase storage logic for handling the file uploads is spot on.

However, because you bypassed local testing, a few structural bugs slipped in that completely break the settings page. Additionally, your editor accidentally ran a formatter (Prettier) over 20 untouched files and modified our package-lock.json, which makes the PR very difficult to review.

Please make the following fixes so we can get this merged:

1. Fix the Public Route (Major Bug)
In React Router v7 / Remix, if you only export the default component, the route will have no data! The useLoaderData hook will crash, and forms will return a 405 Method Not Allowed error.
In app/routes/settings-public.tsx, you must re-export the loader and action so the route actually functions:

export { default, loader, action } from "./settings";

2. Form File Input is outside the <Form> (Bug)
In app/blocks/settings/account-settings.tsx, you added encType="multipart/form-data" to the <Form> (great catch!). However, your new <input type="file" name="avatar"> is physically located outside of the <Form> tags (lines 13-20). When the user clicks "Save Changes", the browser will not send the avatar file because it isn't inside the form element!
Fix: Please move the <Form method="post"> opening tag higher up so it wraps the entire avatarRow section as well.

3. Cleanup the Git Noise
Right now, this PR touches 20 files, but most of those are just your editor automatically changing spaces/formatting in files you didn't actually edit. You also accidentally committed changes to package-lock.json.
Please revert the files you didn't conceptually change so this PR only contains the actual settings route logic. You can easily discard changes to the lockfile by running:
git checkout origin/main -- package-lock.json

Once you apply these fixes and clean up the extra files, we'll be ready to merge. Let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ECSoC26 Required label for ECSOC Sentinel scoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants