Skip to content

Connect Income Statement to Real Data#113

Open
supriya1411 wants to merge 1 commit into
rushikesh-bobade:mainfrom
supriya1411:main
Open

Connect Income Statement to Real Data#113
supriya1411 wants to merge 1 commit into
rushikesh-bobade:mainfrom
supriya1411:main

Conversation

@supriya1411

Copy link
Copy Markdown

Summary

  • Removed mock data usage from the income statement components.
  • Connected the components to real loader data (sales and expenses).
  • Updated the detailed statement table and monthly breakdown chart to use actual database values.

Fixes #21

@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

@supriya1411 is attempting to deploy a commit to the participationcorner2025-8967's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the ECSoC26 Required label for ECSOC Sentinel scoring label Jul 5, 2026
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

📝 Summary

The provided pull request diff appears to be removing import statements for mock data in two separate components: detailed-statement-table.tsx and monthly-breakdown-chart.tsx. This change suggests that the components might be transitioning towards using real data or alternative mock data sources.

📂 Files Changed

  • app/blocks/income-statement/detailed-statement-table.tsx: Removed import statement for mockSales.
  • app/blocks/income-statement/monthly-breakdown-chart.tsx: Removed import statement for mockCashFlow.

🎭 Code Poem

Changes are made with careful might,
Mock data imports removed from sight.
Components updated, code refined,
Performance and readability aligned.

🚨 Bugs & Architectural Violations Looks solid! The changes do not introduce any obvious bugs, security issues, or architectural violations. The components are correctly placed in the `app/blocks/` directory, and there is no evidence of Tailwind CSS usage. However, it would be beneficial to verify that the removal of mock data imports does not break any existing functionality or tests.
💡 Suggestions & Best Practices * Consider adding comments or documentation to explain the reasoning behind removing the mock data imports, as this can help with future maintainability and understanding of the codebase. * Ensure that the components are properly tested with real or alternative mock data to guarantee they function as expected. * Review the `any[]` type annotations for `sales` and `expenses` props in both components. Using more specific types can improve code readability and help catch potential errors. * Verify that the CSS files (`detailed-statement-table.module.css` and `monthly-breakdown-chart.module.css`) associated with these components follow the performance guidelines, such as using `transform` or `opacity` for animations.

@rushikesh-bobade

Copy link
Copy Markdown
Owner

Hi @supriya1411,

Thank you for opening this PR! I took a look at the code diff, and it appears that this commit only deletes the two import statements at the top of the files.

As we discussed in the Issue thread a few days ago, the actual scope of this issue requires a bit more architectural work. Before we can merge this and award the points, you will need to push additional commits to this branch that accomplish the following:

  1. Utility Extraction: Extract the financial calculations (proceeds, cost basis, net profit) out of the components and into reusable utility functions.
  2. Type Safety: Replace the sales?: any[]; expenses?: any[]; props with strict TypeScript interfaces mapped to our Prisma schema.

Please let me know if you need any guidance on how to extract those calculations or define the TypeScript interfaces! Once those architectural changes are pushed to this branch, I will be happy to review it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ECSoC26 Required label for ECSOC Sentinel scoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connect Income Statement to Real Data

2 participants