feat(ui): add reusable Skeleton loading component#107
Conversation
The Skeleton component serves as a loading placeholder with customizable dimensions and shapes.
📝 SummaryThe provided pull request introduces a new 📂 Files Changed
🎭 Code PoemCode so fine, with styles divine, 🚨 Bugs & Architectural Violations* The `Skeleton` component is placed in the `app/components/` directory, which violates the rule of placing UI components in the `app/blocks/` directory. It should be moved to `app/blocks/__global/` or a similar directory. * The code does not seem to have any other critical architectural violations or bugs.💡 Suggestions & Best Practices* Consider adding a `defer` function to the component's loader to improve performance. * The `aria-hidden` attribute is correctly used to keep the component out of the accessibility tree. * The component's styles are well-organized, and the use of CSS variables for theming is a good practice. * The code is well-documented, and the example usage is helpful. * Consider adding more test cases to ensure the component works as expected in different scenarios. |
|
Hi! Thanks for maintaining FlipTrack 🙌 This PR adds a small, reusable Skeleton loading component for data-heavy One thing to confirm — I assumed dark mode uses [data-theme="dark"]. |
Adds a lightweight, reusable Skeleton placeholder for loading states in
data-heavy views (inventory tables, price cards, charts). Reduces layout
shift and improves perceived performance during data fetches.
Note: dark-mode selector currently assumes [data-theme="dark"] — happy to
adjust to match the project's theming approach.