fix: Rework POH Dynamic portal naming#14068
Merged
runelite-github-app[bot] merged 2 commits intoJul 20, 2026
Merged
Conversation
jcbmcn
changed the title
|
Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve 3 bugs with better dynamic name generation:
Closes jcbmcn/poh-portal-labels#41 — portals on upper floors not labeled (scan is plane-agnostic)
Closes jcbmcn/poh-portal-labels#43 — labels missing under the Wilderness house theme (no theme-specific IDs)
Closes jcbmcn/poh-portal-labels#44 — Varrock/Grand Exchange not labeled (shared model, distinct varbit)