Skip to content

Update farming-profit#13137

Merged
riktenx merged 5 commits into
runelite:masterfrom
JaredEzz:bump-author-fix
Jul 1, 2026
Merged

Update farming-profit#13137
riktenx merged 5 commits into
runelite:masterfrom
JaredEzz:bump-author-fix

Conversation

@JaredEzz

@JaredEzz JaredEzz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Set author= to the current maintainer (JaredEzz). Original authorship stays credited in the plugin's README Attribution section and LICENSE per BSD-2-Clause.

@runelite-github-app

runelite-github-app Bot commented Jul 1, 2026

Copy link
Copy Markdown

@runelite-github-app

runelite-github-app Bot commented Jul 1, 2026

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@JaredEzz

JaredEzz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

This update now also fixes a client crash in the currently-live 1.0.0: IconStyle was package-private while FarmingProfitConfig (a public interface) exposes it as a config-item return type, so RuneLite's dynamic config proxy throws IllegalAccessError under the real Hub external-plugin classloader (doesn't repro in a dev/gradle-run client, since that shares one classloader) — crashes the client shortly after login. Fixed by making the enum public. Would appreciate a look given it's actively affecting installed users. Thanks!

@riktenx
riktenx merged commit 9ae77f3 into runelite:master Jul 1, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants