Skip to content

Update loot-lookup to v1.2.2 - fix broken icons#13089

Merged
riktenx merged 1 commit into
runelite:masterfrom
donth77:loot-lookup-v1.2.2
Jul 1, 2026
Merged

Update loot-lookup to v1.2.2 - fix broken icons#13089
riktenx merged 1 commit into
runelite:masterfrom
donth77:loot-lookup-v1.2.2

Conversation

@donth77

@donth77 donth77 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@runelite-github-app

Copy link
Copy Markdown

@runelite-github-app

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx

riktenx commented Jun 30, 2026

Copy link
Copy Markdown
Member

are you able to drop the jsoup dependency and just parse wiki pages syntax by querying them with ?action=raw?

this would allow you to set build=standard and then your plugin could be automatically reviewed and updated by the bot

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jun 30, 2026
@donth77

donth77 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

@riktenx
I looked into this, and unfortunately querying with ?action=raw doesn't return the full drop tables, so parsing the HTML with jsoup may still be the best option.

The wiki generates some of the tables with Lua modules. For example, {{GemDropTable}} is a wrapper around {{#invoke:GemDropLines|main}} (Module:GemDropLines). That module computes each row from an access rate that varies per monster. The rare table works the same, and the herb and seed tables expand the same way.

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jun 30, 2026
@riktenx
riktenx merged commit 4a006de into runelite:master Jul 1, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants