Remove runbox7lib-related files, speed up folder size calculations - #714
Merged
Conversation
tadzik
changed the title
tadzik
force-pushed
the
tadzik/evict-runbox7lib
branch
from
August 6, 2020 16:28
df92d94 to
894383e
Compare
Contributor
tadzik
force-pushed
the
tadzik/evict-runbox7lib
branch
from
August 6, 2020 18:38
894383e to
e38ffcf
Compare
This uses a new, dedicated API from runbox-searchindex 0.2.0
tadzik
force-pushed
the
tadzik/evict-runbox7lib
branch
from
August 12, 2020 16:47
e38ffcf to
af62c83
Compare
gtandersen
approved these changes
Aug 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In runbox/runbox-searchindex#4 they'll become part of runbox-searchindex, ending the circular dependency between the projects.
This also speeds up folder size calculations by utilizing the new runbox-searchindex APIs (previously implemented in https://github.com/runbox/runbox7/pull/665/files).