Skip to content

web: Test with Node.js 25 instead of 22 (in addition to 24)#21953

Merged
kjarosh merged 1 commit into
ruffle-rs:masterfrom
torokati44:node-js-24-25
Mar 14, 2026
Merged

web: Test with Node.js 25 instead of 22 (in addition to 24)#21953
kjarosh merged 1 commit into
ruffle-rs:masterfrom
torokati44:node-js-24-25

Conversation

@torokati44
Copy link
Copy Markdown
Member

@torokati44 torokati44 commented Oct 17, 2025

Referencing #18780, #20362, and #21950.

This will also necessitate updating the set of required checks for PRs, as usual.

@torokati44 torokati44 added A-web Area: Web & Extensions T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Oct 17, 2025
@danielhjacobs
Copy link
Copy Markdown
Contributor

danielhjacobs commented Oct 17, 2025

I don't mind this and it's how we've done updates in the past, but worth noting the odd number releases always have significantly shorter life-cycles than the even number releases. Node 22 will remain the maintenance release for over a year after Node 25 goes entirely out of maintenance: https://nodejs.org/en/about/previous-releases#release-schedule

@danielhjacobs
Copy link
Copy Markdown
Contributor

danielhjacobs commented Oct 17, 2025

Still, the point of the tests is to catch breaking issues as early as possible, and the builds are still being done with even number releases, so it's probably fine. There's just the opposite argument to be had about testing for breakages with the maintenance release too. If CI resources were infinite, we'd ideally test both, but 🤷

@torokati44 torokati44 added the waiting-on-review Waiting on review from a Ruffle team member label Nov 10, 2025
@torokati44 torokati44 force-pushed the node-js-24-25 branch 2 times, most recently from 470848a to b8eab21 Compare December 15, 2025 15:30
@torokati44
Copy link
Copy Markdown
Member Author

torokati44 commented Jan 14, 2026

I can has merge plz

@kjarosh kjarosh enabled auto-merge (rebase) March 14, 2026 11:51
@kjarosh kjarosh removed the waiting-on-review Waiting on review from a Ruffle team member label Mar 14, 2026
@kjarosh kjarosh merged commit 9e06430 into ruffle-rs:master Mar 14, 2026
26 checks passed
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Mar 15, 2026
@Hancock33
Updates on Mar 15, 2026 09:04
ffd7990 
----------------------------------------------------------------------------------------------
es-theme-carbon.mk cf18f9f11447c02d91c9f3ae07eed4c4de067f01 # Version: Commits on Mar 15, 2026
----------------------------------------------------------------------------------------------
some updates,

---------------------------------------------------------------------------------------
amiberry.mk 10c7a3ec9b0f4333c61b30f6489ab1e7ff765f6a # Version: Commits on Mar 15, 2026
---------------------------------------------------------------------------------------
fix(ppa): add workflow_call trigger and dynamic version to ppa-upload.yml

Same GITHUB_TOKEN trigger fix as update-repos.yml: ppa-upload.yml now

exposes a workflow_call trigger so c-cpp.yml can call it directly after

create-release, bypassing the event suppression.

Additional fixes:

- Version is now derived from the git tag at runtime (TAG#v strips the

  leading 'v', so v8.0.0 -> 8.0.0) instead of reading the hardcoded

  version from debian/changelog

- dch --create writes a fresh changelog entry for each release, so the

  committed debian/changelog placeholder is never used by the workflow

- dput.cf written with printf instead of heredoc (heredoc at column 0

  caused YAML parse errors)

- Upgraded actions/checkout to v5 for consistency

- Removed job-level if: condition (caller in c-cpp.yml gates on

  !startsWith(github.ref_name, 'preview-v') instead)

c-cpp.yml: add upload-ppa job (needs: create-release, stable only),

-------------------------------------------------------------------------------------
azahar.mk d97da17263094b474e046c0b5f55b42131937ddf # Version: Commits on Mar 14, 2026
-------------------------------------------------------------------------------------
android: Fixed installed app shortcut creation failing on vanilla,

------------------------------------------------------------------------------------------
dolphin-emu.mk b6027da5db00abd73041d794fbb7b8d7887725dc # Version: Commits on Mar 15, 2026
------------------------------------------------------------------------------------------
Merge pull request #14464 from Dentomologist/system_use_forward_declarations_in_system.h

System: Use forward declarations in System.h,

-----------------------------------------------------------------------------------
eden.mk f0a4ac7359b6de6d6f1926c795831de01d4119d5 # Version: Commits on Mar 15, 2026
-----------------------------------------------------------------------------------
[frontend] only set https on Android (#3733)

--------------------------------------------------------------------------------------
openmsx.mk 26da2b346301dcb51ceef0d40d4cc1b1ce291b18 # Version: Commits on Mar 15, 2026
--------------------------------------------------------------------------------------
Fix #2094: Error when auto saving last setup

    openMSX/openMSX#2094

Problem was in MSXMotherBoard::storeAsSetup(), the (level 4) loop that

goes over all media (around line 435). And then more specifically in the

implementation of CartridgeSlotManager::Slot::getMediaInfo(). It

returned the (possibly relative) filename as was originally given, but

other MediaInfoProvider implementations return an absolute path. This

means that if later you try to save the setup from a different 'cwd',

then the file won't be found. Easily fixed once the problem was

identified.

\target\#,

-------------------------------------------------------------------------------------
ppsspp.mk 4c4081f39e5ecc425ce2cb93e8cec722c12f28be # Version: Commits on Mar 14, 2026
-------------------------------------------------------------------------------------
Merge pull request #21441 from hrydgard/wasapi-error-handling

Windows audio: Improve WASAPI error handling,

------------------------------------------------------------------------------------
rpcs3.mk 16277576089e1733987deeac54b627b25d67d800 # Version: Commits on Feb 19, 2026
------------------------------------------------------------------------------------
SPU LLVM: Emulate GBB with udot/sdot

Greatly simplifies GB, GBH, and GBH. Uses udot/sdot with power of two

masks to shift values and sum them in a single step, effectively

gathering them,

---------------------------------------------------------------------------------------
touchhle.mk de5d312da3ddb718e43878f9476a22b2a250738e # Version: Commits on Feb 28, 2026
---------------------------------------------------------------------------------------
Delay MPMoviePlayerPlaybackDidFinishNotification by 1 second on play.

This is needed in order to avoid regression with playback in BIA and

Hero of Sparta after future coroutines introduction.

Loosely based on https://review.gerrithub.io/c/touchHLE/touchHLE/+/1220415

Co-authored-by: abnormalmaps <abnormalmaps@gmail.com>

Change-Id: I7bb293668ba9186f8a37289ddef3dfd846ac8788,

-------------------------------------------------------------------------------------------
xenia-canary.mk fdd583eced9dd1d9749099b1c27ea76f8fd4c04e # Version: Commits on Mar 15, 2026
-------------------------------------------------------------------------------------------
[GPU/WGF] Fix resolve_fast_32bpp_4xmsaa sample addressing

For 4xMSAA 32bpp, samples 2/3 add a +4 byte horizontal offset to the

EDRAM address. The old typed buffer code (Buffer<uint4>) implicitly

truncated this offset via integer division (>> 2), and the .yw swizzle

compensated by selecting odd elements within the aligned uint4 load.

After the ByteAddressBuffer conversion, Load4 uses the exact byte

address including the +4 offset, shifting the load window by one dword.

The .yw swizzle then picks samples from the wrong pixels, causing

visual artifacts like vertical streaks in Resident Evil 5.

Fix by aligning the load address down to 16 bytes and selecting the

swizzle based on whether the address was offset.,

-------------------------------------------------------------------------------------------
xenia-native.mk fdd583eced9dd1d9749099b1c27ea76f8fd4c04e # Version: Commits on Mar 15, 2026
-------------------------------------------------------------------------------------------
[GPU/WGF] Fix resolve_fast_32bpp_4xmsaa sample addressing

For 4xMSAA 32bpp, samples 2/3 add a +4 byte horizontal offset to the

EDRAM address. The old typed buffer code (Buffer<uint4>) implicitly

truncated this offset via integer division (>> 2), and the .yw swizzle

compensated by selecting odd elements within the aligned uint4 load.

After the ByteAddressBuffer conversion, Load4 uses the exact byte

address including the +4 offset, shifting the load window by one dword.

The .yw swizzle then picks samples from the wrong pixels, causing

visual artifacts like vertical streaks in Resident Evil 5.

Fix by aligning the load address down to 16 bytes and selecting the

swizzle based on whether the address was offset.,

---------------------------------------------------------------
ruffle.mk nightly-2026-03-15 # Version: Commits on Mar 15, 2026
---------------------------------------------------------------
## What's Changed

* chore: Bump undici from 6.23.0 to 6.24.0 in /web by @dependabot[bot] in ruffle-rs/ruffle#23241

* web: Test with Node.js 25 instead of 22 (in addition to 24) by @torokati44 in ruffle-rs/ruffle#21953

* avm1: Implement clipRect support for BitmapData.draw by @evilpie in ruffle-rs/ruffle#23191

**Full Changelog**: ruffle-rs/ruffle@nightly-2026-03-13...nightly-2026-03-15,

---------------------------------------------------------------------------------------
corsixth.mk 4dc8f3a0334c3cca933f7c38a1fddf90a4aa21e8 # Version: Commits on Mar 15, 2026
---------------------------------------------------------------------------------------
Move empty table check to utility. (#3274)

Also drop a slower function that was used for the same test.,

------------------------------------------------------------------------------------------
fallout2-ce.mk c352107b09154ccf3cf3b6600a2bc9d5c6ca5f40 # Version: Commits on Mar 15, 2026
------------------------------------------------------------------------------------------
Dobfuscate region, game_sound, art (#300),

---------------------------------------------------
nblood.mk r14332 # Version: Commits on Mar 14, 2026
---------------------------------------------------
,

----------------------------------------------------------------------------------
stk.mk 8067e13f5bd2d08ad9aadb506ae704df4698fb26 # Version: Commits on Mar 15, 2026
----------------------------------------------------------------------------------
Use wiimote accelerometer calibration offset (#5658),

----------------------------------------------------------------------------------------
supertux2.mk 4599ef686ba4a8cececcbf89fa511f06730008da # Version: Commits on Mar 15, 2026
----------------------------------------------------------------------------------------
NEWS: it's 2026... not 2025.

[[skip ci]]

Signed-off-by: Swagtoy <me@ow.swag.toys>,

--------------------------------------------------------------------------------------------
vpinball-next.mk c292ee29b96c5463d0131d2124931cb10e02d9dc # Version: Commits on Mar 14, 2026
--------------------------------------------------------------------------------------------
OpenXR: add preliminary support for XR controllers,

----------------------------------------------------------------------------------------
doomretro.mk b9a3d877c570e1585eff00b89dd595b8b3cd67d1 # Version: Commits on Mar 15, 2026
----------------------------------------------------------------------------------------
Fix previous commit,

--------------------------------------------------------------------------------------
yquake2.mk 5a3cce2dc9548ec9f54012ac760f08626b071c97 # Version: Commits on Mar 14, 2026
--------------------------------------------------------------------------------------
cppcheck: fix warnings,

----------------------------------------------------------------------------------
trx.mk 694139cb8617736078d9f45aaff9562547e078d2 # Version: Commits on Mar 14, 2026
----------------------------------------------------------------------------------
objects/missile: spawn blood from harpoons

This updates TR3 missile harpoons to spawn blood when they hit Lara.,

-----------------------------------------------------------------------------------------------
libretro-dolphin.mk ab0db892052b0f11b741b177d712ce3b01ff5079 # Version: Commits on Mar 14, 2026
-----------------------------------------------------------------------------------------------
Merge tag 'refs/tags/2603' into uwp-fix

Release for March 2026,

-------------------------------------------------------------------------------------------------
libretro-geargrafx.mk 7aec1792137b21e6153e39bafa2994a21682a3d2 # Version: Commits on Mar 15, 2026
-------------------------------------------------------------------------------------------------
Fix memory leak on failed CUE load chunk,

----------------------------------------------------------------------------------------------
libretro-ppsspp.mk 4c4081f39e5ecc425ce2cb93e8cec722c12f28be # Version: Commits on Mar 14, 2026
----------------------------------------------------------------------------------------------
Merge pull request #21441 from hrydgard/wasapi-error-handling

Windows audio: Improve WASAPI error handling,

-------------------------------------------------------------------------------------------------
libretro-vaporspec.mk e24fcc4939d5b1673d1ade86e3dda6dd2487da9c # Version: Commits on Mar 14, 2026
-------------------------------------------------------------------------------------------------
remove paint screenshot,

-------------------------------------------------------------------------------------
dhewm3.mk 098f77e96db22527f5405bc9a3d7a441625aa493 # Version: Commits on Mar 15, 2026
-------------------------------------------------------------------------------------
imgui_savestyle.cpp ReadImGuiStyle(): don't forget fclose()

and fix a typo,
@torokati44 torokati44 mentioned this pull request May 7, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjarosh kjarosh kjarosh approved these changes

Assignees

No one assigned

Labels

A-web Area: Web & Extensions T-chore Type: Chore (like updating a dependency, it's gotta be done)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@torokati44 @danielhjacobs @kjarosh