Skip to content

Totally disable the DFLTCC extension before tests#111

Merged
junaruga merged 1 commit into
ruby:masterfrom
nobu:dfltcc-s390x
Oct 21, 2025
Merged

Totally disable the DFLTCC extension before tests#111
junaruga merged 1 commit into
ruby:masterfrom
nobu:dfltcc-s390x

Conversation

@nobu

@nobu nobu commented Oct 18, 2025

Copy link
Copy Markdown
Member

No description provided.

@nobu nobu requested a review from junaruga October 18, 2025 08:48
@junaruga

Copy link
Copy Markdown
Member

I am happy to review this PR. I will let you know once I finish reviewing it. :)

@junaruga

junaruga commented Oct 20, 2025

Copy link
Copy Markdown
Member

I reviewed, and tested this PR. It looks good to me. Thanks for the PR.

I have no idea why I chose such a more complicated implementation adding one Rake task test_internal, when adding the ENV["DFLTCC"] = "0" on s390x in the past.

@junaruga junaruga merged commit 6035c53 into ruby:master Oct 21, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants