Don't print useless prompt before escape sequence#839
Merged
Conversation
Reline used to print prompt in nomultiline mode before printing any escape sequence because readline-ext's test was requiring. Removing this behavior because it causes line-wrapped long prompt displayed twice. Test code that depend on this behavior needs to be modified.
|
Thank you for fixing this! I did find that line as suspicious and tried removing it, but saw one failing test and decided to not dig further and report the problem instead 😅 I'll gladly update Bundler specs to match correct behavior 👍. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #833
Reline used to print prompt in nomultiline mode before printing any escape sequence because readline-ext's test was requiring.
It's completely useless because printed prompt will be cleared immediately.
This behavior causes line-wrapped long prompt displayed twice.
Before:
After:
Side effect
Test code that depend on this behavior needs to be modified.
bundler/spec/commands/info_spec.rbbundler/spec/commands/show_spec.rb