Skip to content

Fix quoted insert with invalid byte input#836

Merged
ima1zumi merged 1 commit into
ruby:masterfrom
tompng:fix_quoted_insert_timeout
Jul 15, 2025
Merged

Fix quoted insert with invalid byte input#836
ima1zumi merged 1 commit into
ruby:masterfrom
tompng:fix_quoted_insert_timeout

Conversation

@tompng

@tompng tompng commented Jul 5, 2025

Copy link
Copy Markdown
Member

quoted_insert timeout was 1000 times larger. (forgot to do .fdiv(1000))
Fix a bug that readline unexpedly end when quoted_insert timed out. (Avoid insert_raw_char char=nil and use '' instead when timed out)

Fix this bug:

$ LANG=C irb
irb(main):001> (input \C-v あ)
(irb hangs and exits after 500 second)

quoted_insert timeout was 1000 times larger.
Fix a bug that readline unexpedly end when quoted_insert timed out.

@ima1zumi ima1zumi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ima1zumi ima1zumi merged commit 5f0327e into ruby:master Jul 15, 2025
44 checks passed
@tompng tompng deleted the fix_quoted_insert_timeout branch July 15, 2025 16:39
@ima1zumi ima1zumi added the bug Something isn't working label Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants