Skip to content

Add validation for Encoding.default_external #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompng merged 2 commits into from
Jun 23, 2025
Merged

Add validation for Encoding.default_external #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cee29cb
Add validation for Encoding.default_external
ksaito422 May 29, 2025
debc103
Fix raise InvalidInputrc exception for invalid byte sequences
ksaito422 Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/reline/config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,11 @@ def read_lines(lines, file = nil)
if_stack = []

lines.each_with_index do |line, no|
# Even after encoding conversion, we need to verify the encoding is valid
# as some invalid byte sequences might pass through the conversion.
unless line.valid_encoding?
raise InvalidInputrc, "#{file}:#{no + 1}: can't be converted to the locale #{Reline.encoding_system_needs.name}"
end
next if line.match(/\A\s*#/)

no += 1
Expand Down
17 changes: 17 additions & 0 deletions test/reline/test_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,4 +613,21 @@ def test_reload
@config.reload
assert_equal '@', @config.emacs_mode_string
end

def test_invalid_byte_sequence_inputrc
lines = [
"set vi-cmd-mode-string\n",
"$if Ruby\n",
" \"\C-a\": \"Ruby\"\n",
"$else \"\xFF\"\n".dup.force_encoding(Reline.encoding_system_needs), # Invalid byte sequence
" \"\C-b\": \"NotRuby\"\n",
"$endif\n"
]

e = assert_raise(Reline::Config::InvalidInputrc) do
@config.read_lines(lines, "INPUTRC")
end

assert_equal "INPUTRC:4: can't be converted to the locale #{Reline.encoding_system_needs}", e.message
end
end