Skip to content

Fix flaky DirSingletonTest GC failures in test_fchdir and test_for_fd #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soutaro merged 2 commits into from
Jun 18, 2026
+8 −2
Merged

Fix flaky DirSingletonTest GC failures in test_fchdir and test_for_fd #3004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb9ef2d
Fix flaky DirSingletonTest#test_fchdir under aggressive GC
hsbt Jun 18, 2026
4660929
Apply the same GC fix to DirSingletonTest#test_for_fd
hsbt Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/stdlib/Dir_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ def test_exist?
end

def test_fchdir
fd = Dir.new(Dir.pwd).fileno
dir = Dir.new(Dir.pwd)
fd = dir.fileno

with_int(fd) do |int|
assert_send_type(
Expand All @@ -117,6 +118,8 @@ def test_fchdir
Dir, :fchdir, int, &proc { "string" }
)
end
ensure
dir&.close
end

def test_foreach
Expand All @@ -130,14 +133,17 @@ def test_foreach
end

def test_for_fd
fd = Dir.new(Dir.pwd).fileno
dir = Dir.new(Dir.pwd)
fd = dir.fileno

with_int(fd) do |int|
assert_send_type(
"(::int) -> ::Dir",
Dir, :for_fd, int
)
end
ensure
dir&.close
end

def test_getwd
Expand Down
Loading