[Feature] Add Sheet initial open state#402
Open
pierry01 wants to merge 1 commit into
Open
Conversation
cirdes
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
open:keyword toRubyUI::Sheetso a Sheet can render already open on the initial response — noSheetTriggerclick required.Why
When a Sheet is rendered as the result of a Turbo Stream (or any server-driven render where the user did not click a trigger), there is no
SheetTriggerin scope to open it. Today the only way to surface the Sheet is to dispatch the controller'sopenaction manually from JS.Use case: clicking a table row dispatches a
GETacceptingtext/vnd.turbo-stream.html; the response targets aturbo_frame_tagin the layout withturbo_stream.update("FRAME_ID", Sheet(open: true) { ... }). The Sheet appears as soon as the stream lands.Implementation
RubyUI::Sheet#initializenow acceptsopen: falseand forwards remaining**attrstosuper.default_attrsexposes the value to Stimulus viadata-ruby-ui--sheet-open-value.sheet_controller.jsdeclaresstatic values = { open: false }and callsthis.open()onconnect()whenopenValueis true.false, so existing usage is unchanged.Tests
test_render_closed_by_default— confirms the data attribute defaults to"false".test_render_open_when_open_is_true— confirmsSheet(open: true)emitsdata-ruby-ui--sheet-open-value="true".Existing test (
test_render_with_all_items) still passes — additive change only.Summary by cubic
Adds an
open:option toRubyUI::Sheetto render a Sheet already open on the initial response. Enables Turbo Stream/server-driven renders to show the Sheet without aSheetTrigger; defaults to closed for backward compatibility.open:toRubyUI::Sheet, exposingdata-ruby-ui--sheet-open-valuefor Stimulus.openValueand callsopen()on connect when true.Written for commit 3aad267. Summary will update on new commits. Review in cubic