Skip to content

fix: resolve management group display names to IDs #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtellin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resolve management group display names to IDs #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions CLOUD/Get-AzureSizingInfo.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ may take a long time when large blob stores are located.


.PARAMETER ManagementGroups
A comma separated list of Azure Management Groups to gather data from.
A comma separated list of Azure Management Group IDs or display names to gather data from.
If a display name is provided, the script will attempt to resolve it to the management group ID.

.PARAMETER GetKeyVaultAmounts
Gets number of key vaults, and amount of certificates, keys, and secrets in each key vault. One must add the
Expand Down Expand Up @@ -581,9 +582,22 @@ switch ($PSCmdlet.ParameterSetName) {
$subs = @()
foreach ($managementGroup in ($ManagementGroups -split ',' | ForEach-Object { $_.Trim() })) {
try {
# Search-AzGraph requires the management group ID, not the display name.
# Attempt to resolve the input as a display name first.
$mgId = $managementGroup
try {
$allMGs = Get-AzManagementGroup -ErrorAction Stop
$match = $allMGs | Where-Object { $_.DisplayName -eq $managementGroup }
if ($match) {
$mgId = $match.Name
Write-Host "Resolved management group display name '$managementGroup' to ID '$mgId'" -ForegroundColor Green
}
} catch {
Write-Host "Could not query management groups to resolve display name, using '$managementGroup' as-is" -ForegroundColor Yellow
}
$subscriptionNames = $(Search-AzGraph `
-Query "ResourceContainers | where type =~ 'microsoft.resources/subscriptions'" `
-ManagementGroup $managementGroup -ErrorAction Stop).name
-ManagementGroup $mgId -ErrorAction Stop).name
foreach ($subName in $subscriptionNames) {
$sub = Get-AzSubscription -TenantId $context.Tenant.Id -SubscriptionName $subName -ErrorAction Stop
$subs += $sub
Expand Down