Skip to content
This repository was archived by the owner on Jun 25, 2026. It is now read-only.

refactor(github): split issues and webhooks clients - #61

Closed
rtzll wants to merge 3 commits into
mainfrom
rascal/rtzll/rascal-15-81094078a9
Closed

refactor(github): split issues and webhooks clients#61
rtzll wants to merge 3 commits into
mainfrom
rascal/rtzll/rascal-15-81094078a9

Conversation

@rtzll

@rtzll rtzll commented Mar 3, 2026

Copy link
Copy Markdown
Owner

Move issue-related and webhook-related API helpers into dedicated files while keeping shared HTTP plumbing in client.go.

Automated changes from Rascal run run_81094078a96d44eb.

Run Details

    __( O)>  ● new session · codex gpt-5.2-codex
   \____)    20260303_1 · /work/repo
     L L     goose is ready
=== CODEX PROVIDER DEBUG ===
Command: "/usr/bin/codex"
Model: gpt-5.2-codex
Reasoning effort: high
Skip git check: false
Prompt length: 1628 chars
Prompt: You are a general-purpose AI agent called goose, created by Block, the parent company of Square, CashApp, and Tidal.
goose is being developed as an open-source software project.
# Response Guidelines

Use Markdown formatting for all responses.

Human: <info-msg>
It is currently 2026-03-03 19:17:00
Working directory: /work/repo

Current tasks and notes:
Once given a task, immediately update your todo with all explicit and implicit requirements

</info-msg>
# Rascal Run Instructions

Run ID: run_81094078a96d44eb
Task ID: rtzll/rascal#15
Repository: rtzll/rascal
Issue: #15

## Task

refactor(github): split webhook and issue APIs into separate files

## Goal
Improve maintainability of GitHub integration by splitting concerns in `internal/github`.

## Scope
- Move issue-related methods/types to `client_issues.go`.
- Move webhook-related methods/types to `client_webhooks.go`.
- Keep shared HTTP plumbing in `client.go`.

## Acceptance Criteria
- Public behavior and method signatures remain stable (unless explicitly improved in issue notes).
- File boundaries reflect concern separation.
- Tests remain green with no regressions.
- `go test ./...` passes.

## Constraints

- Do not ask for interactive input.
- Do not require MCP tools.
- Keep changes minimal and scoped to the requested task.
- Run tests or explain why tests could not run.
- If you make changes, write /rascal-meta/commit_message.txt using a conventional commit title on the first line.
- Optionally add a commit body after a blank line in /rascal-meta/commit_message.txt.

## Additional Context

Triggered by label 'rascal' on issue #15


Assistant: 
Image files: 0
============================
{"type":"message","message":{"id":null,"role":"assistant","created":1772565840,"content":[{"type":"text","text":"**Summary**\n- Split shared HTTP plumbing into `internal/github/client.go:1` and moved issue helpers to `internal/github/client_issues.go:1` and webhook helpers to `internal/github/client_webhooks.go:1`.\n\n**Tests**\n- `go test ./...` fails: `TestCanceledRunDoesNotTransitionToSuccess` timed out waiting for server idle in `cmd/rascald/main_test.go:794`.\n\n**Notes**\n- Wrote commit message in `/rascal-meta/commit_message.txt:1`.\n\nWant me to re-run the failing test in isolation or investigate the timeout?"}],"metadata":{"userVisible":true,"agentVisible":true}}}
{"type":"complete","total_tokens":1507638}

Closes #15


Rascal run took 6m 58s

@rtzll
rtzll force-pushed the rascal/rtzll/rascal-15-81094078a9 branch from af3fff3 to 9bcc4a6 Compare March 5, 2026 19:11
rtzll and others added 3 commits March 7, 2026 11:06
Move issue-related and webhook-related API helpers into dedicated files while keeping shared HTTP plumbing in client.go.

Run: run_81094078a96d44eb
@rtzll
rtzll force-pushed the rascal/rtzll/rascal-15-81094078a9 branch from cba6577 to d3098be Compare March 7, 2026 10:06
@rtzll

rtzll commented Mar 15, 2026

Copy link
Copy Markdown
Owner Author

Closing as stale. The GitHub boundary evolved through later deeper-module refactors, so this older file-splitting branch is no longer worth merging as-is.

@rtzll rtzll closed this Mar 15, 2026
@rtzll
rtzll deleted the rascal/rtzll/rascal-15-81094078a9 branch April 2, 2026 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(github): split webhook and issue APIs into separate files

1 participant