rtksvr: don't clear ephemeris times when initialising#856
Open
ourairquality wants to merge 1 commit into
Open
Conversation
The ephemeris data can be pre-loaded by rtkrcv and rtknavi, and clearing the times when initialising invalidates these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ephemeris data can be pre-loaded by rtkrcv and rtknavi, and clearing the times when initialising invalidates these.
Frustrating that rtkrcv loses nav data and then takes time to acquire it again. It was loading the nav data and then initializing rtksvr which cleared the ephemeris times which stops them being saved unless new nav data is acquired, so quickly starting and stopping rtkrcv would lose the nav data. This patch works around this. Not sure why this clearing of the times was needed, and the users of the data should be checking the times anyway, but might there be a reason for this?