fix(grep): force --with-filename to fix single-file rg output parsing#1725
Open
ShiraiEd wants to merge 1 commit intortk-ai:developfrom
Open
fix(grep): force --with-filename to fix single-file rg output parsing#1725ShiraiEd wants to merge 1 commit intortk-ai:developfrom
ShiraiEd wants to merge 1 commit intortk-ai:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
first colon
--with-filenameto the rg invocation so output always includes the filename prefix regardless of how many files are searchedparse_rg_linehelper for testabilityTest plan
test_parse_rg_line_with_colons_in_content— verifies filename and line number are correct when content contains colonstest_parse_rg_line_single_file_fallback— verifies two-part lines fall back to the provided path(fixes [#1613])