fix: pre-extraction path traversal check in install.sh#1686
Open
ether-btc wants to merge 1 commit intortk-ai:masterfrom
Open
fix: pre-extraction path traversal check in install.sh#1686ether-btc wants to merge 1 commit intortk-ai:masterfrom
ether-btc wants to merge 1 commit intortk-ai:masterfrom
Conversation
Checks archive contents with tar -tf before extraction to block CWE-22 path traversal attempts (../, /./, ..). Refs: rtk-ai#1250
|
H Hermes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1250.
The vulnerability
The installer had no path traversal protection. A malicious mirror or compromised download could serve a tar archive containing
../../etc/cron.d/malwareand overwrite arbitrary filesystem paths.The fix
Use
tar -tfto list archive contents before extraction. Block and exit if any entry contains path traversal patterns (../,/./,..):This is a single pre-extraction check with no architectural changes.
References