fix: report ok for silent npm scripts#1660
Open
sdwolf4103 wants to merge 1 commit intortk-ai:developfrom
Open
Conversation
Collaborator
📊 Automated PR Analysis
SummaryThis PR fixes the npm output filter to treat npm 7+ leading lifecycle echo lines (e.g. script name and command) as boilerplate, so that silent scripts with no substantive output correctly report "ok". It preserves a single leading "> " line as possible user output and keeps "> " lines that appear after real output. Regression tests cover lifecycle-only output, substantive output preservation, and edge cases. Review Checklist
Analyzed automatically by wshm · This is an automated analysis, not a human review. |
e89d228 to
2af091c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ok.>lines after real output and a single leading>line that may be user output.Verification
git diff --check -- src/cmds/js/npm_cmd.rsNote: local environment did not have
cargo/rustc, so Rust tests should run in CI.