ci: enable golangci-lint in CI and clear accumulated findings#11
Merged
Conversation
Address 14 issues that had accumulated because CI never ran the linter. Wrap ignored Close() returns, fix argOrder on the process-state check, ensure the fleet-stream cancel always runs, and lowercase three fmt.Errorf strings. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Adds a lint job pinned to golangci-lint v2.12.2 (matching the version the Makefile already expects locally). Without it, the lint config in .golangci.yml was unenforced and findings accumulated silently. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Bundles lint+test into a single target that mirrors what CI now enforces, and documents it in CLAUDE.md so future agents (and humans) have a clear contract for "ready to push" rather than relying on memory to run both. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
v6 of the action rejects v2.x versions of golangci-lint outright. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lintjob to.github/workflows/ci.yml, pinned togolangci-lint v2.12.2(matches the version the Makefile expects locally).make checktarget (lint test) and document it in CLAUDE.md as the contract for "ready to push," so the gap that let these findings slip in doesn't reopen.Test plan
make lint→ 0 issuesmake test→ all packages pass with-racemake check→ both run from a single target🤖 Generated with Claude Code