Conversation
Id is far easier to use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom support for serialization and deserialization.
This is not a simple
#[derive(Serialize, Deserialize)]. It is a hand crafted implementation to fit theplotive-jstypescript definitions.Therefore any figure written in JSON, YML or Javascript that follows those definitions can be parsed. non-provided fields will keep the default assignment. Ticks, strokes, colors etc. can either be deserialized from string, object or arrays per the typescript definitions.
Similarily, a figure can be automatically serialized into something that looks hand-written (all defaults props are ignored, those that can be simplified are etc.)
For example the minimal example serializes in YML as
whereas implementation with
#[derive(Serialize, Deserialize)]would look like the following which would also be required for deserialization: