This repository was archived by the owner on Jun 17, 2026. It is now read-only.
Fix typo in required_apps for frappe_search#354
Open
iamimmanuelraj wants to merge 1 commit into
Open
Conversation
Frappe expects app name to be in the required apps not the repo name
zeel-codder
approved these changes
Feb 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR corrects the naming convention for the frappe_search dependency in the required_apps list, changing it from a hyphen-separated format to an underscore-separated format to match Python package naming standards.
Changes:
- Updated the required_apps list to use
frappe_searchinstead offrappe-search
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zeel-codder
self-requested a review
February 4, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small update to the
required_appslist innext_crm/hooks.py, correcting the app name for consistency.rtCamp/frappe-searchtortCamp/frappe_searchin therequired_appslist to match the correct naming convention.