Potential fix for code scanning alert no. 15: Workflow does not contain permissions#312
Open
radhe wants to merge 1 commit into
Open
Potential fix for code scanning alert no. 15: Workflow does not contain permissions#312radhe wants to merge 1 commit into
radhe wants to merge 1 commit into
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/rtCamp/login-with-google/security/code-scanning/15
In general, the problem is fixed by explicitly specifying
permissions:for the workflow or for the specific job, instead of relying on the repository/organization defaultGITHUB_TOKENpermissions. This enforces the principle of least privilege and satisfies CodeQL’s requirement that permissions be explicitly limited.For this workflow, the best fix without changing existing functionality is to add a
permissions:block at the job level forrunPHPCSInspection. Since the job runs a code review action that may need to interact with pull requests, we can conservatively grantcontents: read(to read the code) andpull-requests: write(to allow the action to comment/review on the PR if it usesGITHUB_TOKEN). If the action in reality does not need write access,pull-requests: writecould later be removed, but adding it now minimizes the risk of breaking existing behavior. The change should be inserted under the job definition (afterruns-on: ubuntu-latestor before, both are valid YAML) in.github/workflows/phpcs_on_pull_request.yml. No imports or additional files are needed, since this is purely a workflow YAML configuration change.Suggested fixes powered by Copilot Autofix. Review carefully before merging.