Skip to content

hyrolo add test 5 #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matsl merged 4 commits into from
May 12, 2026
+30 −1
Merged

hyrolo add test 5 #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5470990
Test error case of hyrolo-mail-to
matsl May 11, 2026
16a51fc
Add hyrolo-rename test
matsl May 11, 2026
cbbc1ec
Add ChangeLog
matsl May 11, 2026
00aef11
Improve docstring
matsl May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
2026-05-11 Mats Lidell <matsl@gnu.org>

* test/hyrolo-tests.el (hyrolo-tests--mail-to): Test error case.
(hyrolo-tests--rename): Add test.

* test/hyrolo-tests.el: Verify all return values for hyrolo-grep and
hyrolo-fgrep.

Expand Down
28 changes: 27 additions & 1 deletion test/hyrolo-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1671,7 +1671,12 @@ body
(mocklet (((actypes::link-to-compose-mail "second@receiver.org") => t))
(hyrolo-mail-to)))
(kill-buffer hyrolo-display-buffer)
(hy-delete-files-and-buffers hyrolo-file-list))))
(hy-delete-files-and-buffers hyrolo-file-list)))
(with-temp-buffer
(mocklet (((beep) => t))
(ert-with-message-capture cap
(hyrolo-mail-to)
(hy-test-helpers:should-last-message "Invalid buffer or no e-mail address found" cap)))))

(ert-deftest hyrolo-tests--location-movement ()
"Verify movement between location headers."
Expand Down Expand Up @@ -2094,6 +2099,27 @@ Dependencies on the consult package are mocked."
(hyrolo-set-date)
(should (string= "* item\n\t\t\t2025-01-03\n\n\n" (buffer-string))))))))

(ert-deftest hyrolo-tests--rename ()
"Verify `hyrolo-rename' changes the name of the old rolo file."
(defvar new-file)
(let* ((old-file (make-temp-file "hypb" nil ".otl" "old-file"))
(old-file-backup (concat old-file "~"))
(new-file (concat (expand-file-name (make-temp-name "hypb") "/tmp") ".otl"))
(new-file-backup (concat new-file "~")))
(unwind-protect
(with-mock
(mock (hyrolo-get-file-list) => (list new-file))
(mock (hyrolo-prompt 'y-or-n-p *) => t)
(make-empty-file old-file-backup)
(find-file-noselect old-file)
(ert-with-message-capture cap
(hyrolo-rename old-file new-file)
(should (string-search "Your personal rolo file is now" cap)))
(should (file-exists-p new-file-backup))
(with-current-buffer (find-file new-file)
(should (looking-at-p "old-file"))))
(hy-delete-files-and-buffers (list old-file old-file-backup new-file new-file-backup)))))

(provide 'hyrolo-tests)

;; This file can't be byte-compiled without the `el-mock' package
Expand Down