Skip to content

display leaflet in revealjs#57

Open
kazutan wants to merge 2 commits into
rstudio:mainfrom
kazutan:master
Open

display leaflet in revealjs#57
kazutan wants to merge 2 commits into
rstudio:mainfrom
kazutan:master

Conversation

@kazutan
Copy link
Copy Markdown

@kazutan kazutan commented Oct 19, 2017

I love the revealjs package and I always use it.
However, using leaflet with revealjs, MapTiles may not be displayed properly.
That's the cause the style .reveal img {max-height: 95%} .

So, I add styles into default.html to fix this.

@cderv
Copy link
Copy Markdown
Collaborator

cderv commented Sep 21, 2021

It is possible that this is fixed with a new version of revealjs - From quick test, it seems so.
I'll check then merge this is not.

@atusy
Copy link
Copy Markdown
Contributor

atusy commented Sep 21, 2021

@cderv Thank you for taking care of this. I think the fix on revealjs side is better than nothing for now.
Yet, as I mentioned in rstudio/leaflet#668, I wish in the future the fix happens on leaflet side because the same problem may occur outside revealjs, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

widgets widgets support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants