Fix missing semicolon in .d-contents nav a CSS rule#509
Open
soumyaray wants to merge 1 commit into
Open
Conversation
The rule omits the semicolon after 'text-decoration: none', so the CSS parser reads the value as 'none color: rgba(0, 0, 0, 0.8)', which is invalid and drops both the text-decoration and color declarations for table-of-contents links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
.d-contents nav arule in the article template is missing a semicolon aftertext-decoration: none, atinst/rmarkdown/templates/distill_article/resources/distill.html(line 289):Because the declaration isn't terminated, the CSS parser reads the value of
text-decorationasnone color: rgba(0, 0, 0, 0.8). That's an invalid value, so the parser discards the wholetext-decorationdeclaration and consumes thecolorline into it — meaning table-of-contents links get neither the intendedtext-decoration: nonenor thecolor: rgba(0, 0, 0, 0.8).The effect is of course only cosmetic (TOC link color/underline fall back through the cascade).
It seems that the only malformed copy is in
distill.htmlso its an easy fix.Fix
Add the missing semicolon: