Bump grandiose pin to fix macOS arm64 build#96
Open
ktamas77 wants to merge 1 commit into
Open
Conversation
The pinned commit cf09bb84 of rse/grandiose lacks the mac && arm64 case in binding.gyp, so on Apple Silicon grandiose.node builds without linking libndi. The renderer then crashes (SIGSEGV) on the first NDI call. rse/grandiose@456f3132 ("fix ARM64 usage") adds the missing case and a separate ndi/lib/mac-a64/libndi.dylib. After this bump, `electron-builder --mac --arm64` produces a working Vingester.app on Apple Silicon with no patches needed. Verified locally on macOS 26.4 / Apple Silicon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current
grandiosepin (rse/grandiose#cf09bb84) lacks themac && arm64case inbinding.gyp. As a result, on Apple Silicongrandiose.nodebuilds without linkinglibndi, and the app SIGSEGVs on the first NDI call from the renderer.rse/grandiose@456f3132("fix ARM64 usage") adds the missing case along with a separatendi/lib/mac-a64/libndi.dylib. Bumping the pin is a one-line fix that makeselectron-builder --mac --arm64produce a workingVingester.appon Apple Silicon — no patches, no extra config.What changes
Verification
Locally tested on macOS 26.4 / Apple Silicon (M1 Pro):
npm install—grandioserebuilds cleanly via node-gyp 12; the newmac && arm64case inbinding.gypcorrectly copiesmac-a64/libndi.dylibintobuild/Release/and links-lndi.npx electron-builder --mac --arm64— producesdist/mac-arm64/Vingester.app.otool -Lconfirmsgrandiose.nodenow resolves@rpath/libndi.dylib(previously: no libndi dependency at all).tell application "Vingester" to return versionreturns2.8.0. No crash.What this does NOT change
win-x64,lnx-x64,mac-x64, etc.) plus the newmac-a64.vingester-ffmpeg.jsalready handlesarch === "arm64"via@rse/ffmpeg.Notes for the maintainer
node-gyp(12.x) on the build host because the bundled one in olderelectron-rebuildis incompatible with Python 3.12+. Not part of this PR — purely a build-host concern.