Option 2: add typed watch execution planning - #67
Closed
rsanheim wants to merge 3 commits into
Closed
Conversation
Owner
Author
|
not needed anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the focused typed-plan option for the watch execution bug. Watch handling now plans explicit job runs before executing, so a matched job with only missing targets cannot run accidentally with no args. Explicit
no_targetsremains a distinct planned run.What changed
FileEventHandlerto execute only planned runs.no_targets, same-job dedupe, and same-job target plus no-target behavior.watchpackage location and overall public shape.Validation
git diff --checkgo test -mod=mod ./watchbin/rake buildPLUR_BINARY="$PWD/plur" bin/rspec spec/integration/watch/watch_config_spec.rb spec/integration/watch/watch_integration_spec.rb spec/integration/watch/watch_spec.rb spec/integration/watch/mismatched_dirs_spec.rbNotes
This is the smaller implementation option. It fixes the bug while avoiding the broader package-boundary move.