Added magic to fix mimes not working for arbitary video files. - #773
Draft
Lachee wants to merge 5 commits into
Draft
Added magic to fix mimes not working for arbitary video files.#773Lachee wants to merge 5 commits into
Lachee wants to merge 5 commits into
Conversation
Lachee
marked this pull request as draft
June 28, 2026 10:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This properly fixes issue #257 by utilising the built in
mimetypespackage for extensions, and adding thepython-magiclibrary for mime-detection based on content.I was finding there was a lot of video types that were still not being handled correctly by the hand rolled implementation, and i feel it would be more reliable and secure to use a package specifically designed to discern file formats.