Misc fixes - #729
Open
po5 wants to merge 41 commits into
Open
Conversation
This regex caught more than was necessary, and in the process made it impossible to use headers. Only replace instances that will actually trigger tag permalinks.
Right click Copy would not work on Chrome and Firefox. Right click Save would not work on Firefox.
Also fixes a js error.
So that it works regardless of server configuration.
I'm really confused why the user was expected to reload the page, there's no technical reason that I can find for it to be this way.
Fixes the default theme flashing on reload
… div class="transparent"
Collaborator
Author
|
There's a few more that I need to rework before submitting, will get their own PRs. |
user can never be None, we do an assert here and everywhere else this function is called.
Based on rr-#656, plus escaping.
po5
force-pushed
the
misc
branch
2 times, most recently
from
April 1, 2025 07:35
5f34080 to
087ea91
Compare
This was taking multiple seconds, now it's <200ms for the whole /post/ api request. Updating relations is still slow, but that doesn't impact user experience.
Initial calls to api.fetchConfig() in quick succession would launch multiple requests. This should be implemented in Info tbh not outside of it.
To easily filter through posts that haven't been retagged since initial upload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assorted fixes that don't deserve separate PRs but are still worth submitting.
See commit messages for info.
I included 3 commits from @Hunternif that I think deserve to be upstreamed too. Hope that's fine.
Feel free to cherry pick, the commits are unordered and independent of one another. (except for 9f53388 and 7d65f1e that both require f12e288)