client/posts: check reverse search permissions - #724
Open
po5 wants to merge 1 commit into
Open
Conversation
po5
marked this pull request as draft
March 30, 2025 03:51
po5
force-pushed
the
reverse-search-perms
branch
from
April 4, 2025 05:29
7084d83 to
c8c06da
Compare
po5
marked this pull request as ready for review
April 4, 2025 05:29
rr-
reviewed
Sep 22, 2025
rr-
left a comment
rr-
left a comment
Owner
There was a problem hiding this comment.
This makes sense to me.
However, I think it's important to outline the implications of this change in the documentation on the permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I disagree with the reasoning used to shut down this feature request/fix in #424.
The choice should be up to the instance owner, which this PR achieves:
In the event of an identical duplicate, it still reports "Post already uploaded" like usual.