Fixed the tag suggestions being shown as [object Object] when added m… - #696
Merged
Conversation
po5
approved these changes
Mar 25, 2025
Collaborator
|
This PR closes #196. |
Collaborator
|
There's another instance of this, I submitted a PR to your branch: Anbosuki#1 |
client/tags: fix tag suggestions data-key
Collaborator
|
@Anbosuki I'm unable to merge the PR if you delete the branch :^) |
Author
|
@po5 Ah, sorry, I only now noticed what you did :D Yeah, sorry, I reopened the branch and PR ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
when manually adding a tag suggestion to a tag under the tags edit page you cannot actually see it when you want to use it. If you click on the tag while editing a post, you simply see
[object Object], which isn't helpful of course.It can be simply fixed by accessing
suggestion._origName. I tested it and it works without any problems. Even when adding multiple suggestions to an tag it doesn't cause any issues.