Skip to content

impr: support for angular-bootstrap 0.14.x#47

Merged
rpocklin merged 1 commit into
rpocklin:masterfrom
QuentinFchx:impr/support-uib-0.14.x
Oct 14, 2015
Merged

impr: support for angular-bootstrap 0.14.x#47
rpocklin merged 1 commit into
rpocklin:masterfrom
QuentinFchx:impr/support-uib-0.14.x

Conversation

@QuentinFchx

Copy link
Copy Markdown
Contributor

Closes #46

@QuentinFchx

Copy link
Copy Markdown
Contributor Author

Should I also fix the update_tabs call (https://github.com/rpocklin/ui-router-tabs/blob/master/src/ui-router-tabs.js#L93) ?

@rpocklin

Copy link
Copy Markdown
Owner

Thanks I was just making these changes now but i'll accept your PR since you went to the trouble :)

I'll update those (old) comments and do a version release. Thanks for contributing.

rpocklin added a commit that referenced this pull request Oct 14, 2015
Added `uib` prefix for UI Bootstrap elements (for v0.14.0+)
@rpocklin rpocklin merged commit 35004b9 into rpocklin:master Oct 14, 2015
@QuentinFchx

Copy link
Copy Markdown
Contributor Author

Thank you :)

On Wed, Oct 14, 2015 at 10:47 PM, Robert Pocklington <
notifications@github.com> wrote:

Thanks I was just making these changes now but i'll accept your PR since
you went to the trouble :)

I'll update those (old) comments and do a version release. Thanks for
contributing.


Reply to this email directly or view it on GitHub
#47 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants