Fix package types entry#60
Open
luuhongyii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typesfield to the generated declaration file atdist/index.d.tsexportsandtypesVersionsmappings aligned with the same declaration entryProblem
@rpf3/spek@0.95.0publishesdist/index.d.ts, but the package manifest currently advertises:The published package tarball does not include a root
index.d.ts, so tools that read the package-leveltypesfield can resolve to a missing declaration file even though the correct declaration file is already present underdist/.Verification
npm view @rpf3/spek@0.95.0 name version types exports --jsonnpm pack @rpf3/spek@0.95.0 --dry-run --ignore-scripts --jsonconfirms rootindex.d.tsis absent anddist/index.d.tsis presentcorepack pnpm@8.15.9 install --frozen-lockfile --ignore-scriptscorepack pnpm@8.15.9 exec svelte-kit synccorepack pnpm@8.15.9 run packagecorepack pnpm@8.15.9 run checkpasses with 0 errors and 4 existing accessibility warningsnpm pack --dry-run --ignore-scripts --jsonafter package generation confirms the configuredtypesfile exists in the packed file listgit diff --checkNote
corepack pnpm@8.15.9 test -- --reporter=listcurrently exits withNo tests found; I left that unrelated test-suite setup issue out of this focused manifest fix.