Fix Windows VBS launcher Python detection - #9
Draft
rpatel622 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
pyw.exedetection path with explicit support for the standard Windowspy.exelauncher.pythonw.exeinstallations.Root cause
The original VBS launcher checked only the executable portion of entries such as
pyw.exe -3.11.pyw.exeis not consistently installed, while the standard Windows launcher is usuallypy.exe. The version arguments were also not included in the original availability check.Validation needed
This should be tested on Windows with:
The GitHub connector environment cannot execute Windows Script Host, so native Windows validation is still required.