feat: add lightweight verification review#55
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a lightweight verification review step to the verification process, requiring a scoped code review focused on correctness, security, and edge cases without running full spec or design drift checks. This change is documented in both English and Chinese skill files, and corresponding test assertions have been added. The reviewer feedback suggests localizing the English word "correctness" to "正确性" in the Chinese skill file and updating the corresponding test assertions to maintain consistency.
| 3. 编译通过（执行项目对应的构建命令，如 `npm run build`、`mvn compile`、`cargo build` 等） | ||
| 4. 相关测试通过 | ||
| 5. 无明显安全问题（无硬编码密钥、无新增 unsafe 操作） | ||
| 6. 简化代码审查通过：派发 code-reviewer 子 agent，只检查 correctness、安全、边界条件 |
There was a problem hiding this comment.
In the Chinese version of the skill, the English word "correctness" is used in the checklist item, whereas "正确性" is used in the subsequent paragraph (line 96). To maintain language consistency and proper localization, "correctness" should be translated to "正确性".
| 6. 简化代码审查通过：派发 code-reviewer 子 agent，只检查 correctness、安全、边界条件 | |
| 6. 简化代码审查通过：派发 code-reviewer 子 agent，只检查正确性、安全、边界条件 |
| - spec scenario 覆盖率 | ||
| - design doc 一致性深度比对 | ||
| - code pattern consistency 建议 | ||
| - 不影响 correctness、安全、边界条件的 code pattern consistency 建议 |
There was a problem hiding this comment.
Similarly, "correctness" in the skipped items list should be translated to "正确性" for consistency with the rest of the Chinese document.
| - 不影响 correctness、安全、边界条件的 code pattern consistency 建议 | |
| - 不影响正确性、安全、边界条件的 code pattern consistency 建议 |
| expect(zhVerify).toContain('CRITICAL 失败项必须修复'); | ||
| expect(zhVerify).toContain('不允许跳过修复直接全部接受'); | ||
| expect(zhVerify).toContain('简化代码审查'); | ||
| expect(zhVerify).toContain('只检查 correctness、安全、边界条件'); |
There was a problem hiding this comment.
Since we are translating "correctness" to "正确性" in the Chinese skill file, the corresponding test assertion needs to be updated to match the localized string.
| expect(zhVerify).toContain('只检查 correctness、安全、边界条件'); | |
| expect(zhVerify).toContain('只检查正确性、安全、边界条件'); |
|
Please fix the issues in the Gemini review first. |
|
已经解决Gemini评论中的问题。 |
2 participants
Summary
Test Plan
npx vitest run test/ts/skills.test.tsgit diff --check origin/master..HEADNotes
npx vitest runcurrently fails intest/ts/init-e2e.test.tsbecause the clean-directory init fixture cannot find.claude/skillsin the temporary Lingma Superpowers staging directory, which also leaves.codex/skills/comet/SKILL.mdabsent.