This repository was archived by the owner on Jan 26, 2022. It is now read-only.
PR: Add setuptools setup file, add command to compile CUDA/C libraries and general package file refactoring#84
Open
andfoy wants to merge 27 commits into
Open
PR: Add setuptools setup file, add command to compile CUDA/C libraries and general package file refactoring#84andfoy wants to merge 27 commits into
andfoy wants to merge 27 commits into
Conversation
Author
|
For instance, the main Detectron package has done the refactoring as well: facebookresearch/Detectron#414 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your great work and effort in porting Detectron to PyTorch!
This PR adds a compatible setuptools distributable setup file, this addition allows other reseachers/developers to embed Detectron in their applications without having to modify the
PYTHON_PATHenvironment variable, instead, they just have to import the library usingimport detectron_pytorch.It also adds a magic command to execute the
make.shscript by invokingpython setup.py build_static. Finally, it presents a new package structure.I'm pending of any requests or additions this PR should have.