feat: allow disabling sign-in link behavior#66
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a feature toggle to disable the automatic smart-paste sign-in link fallback by injecting app config into the sign-in link API and introducing a new flag in RowndConfig. Entity relationship diagram for RowndConfig and SignInLinkApierDiagram
ROWND_CONFIG {
Boolean forceInstantUserConversion
Boolean enableDebugMode
Boolean enableSmartLinkPasteBehavior
}
SIGN_IN_LINK_API {
KtorApiClient apiClient
RowndConfig config
}
SIGN_IN_LINK_API ||--|| ROWND_CONFIG : injects
Class diagram for updated RowndConfig and SignInLinkApiclassDiagram
class RowndConfig {
+Boolean forceInstantUserConversion
+Boolean enableDebugMode
+Boolean enableSmartLinkPasteBehavior
+String getApiBaseUrl()
}
class SignInLinkApi {
+KtorApiClient apiClient
+RowndConfig config
+SignInLink createSignInLink()
+void handleSignInLinkIntent(ctx)
}
SignInLinkApi --> RowndConfig : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Simplify the nested control flow by checking enableSmartLinkPasteBehavior early (and returning if false) to reduce indentation.
- Extract the clipboard-paste logic into a single helper method to remove duplication between the focus and layout branches.
- Review the use of @transient on enableSmartLinkPasteBehavior—if you need this flag to be persisted or driven by remote config, it shouldn’t be marked transient.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Simplify the nested control flow by checking enableSmartLinkPasteBehavior early (and returning if false) to reduce indentation.
- Extract the clipboard-paste logic into a single helper method to remove duplication between the focus and layout branches.
- Review the use of @Transient on enableSmartLinkPasteBehavior—if you need this flag to be persisted or driven by remote config, it shouldn’t be marked transient.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
BobbyRadford
approved these changes
Oct 27, 2025
mhamann
added a commit
that referenced
this pull request
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Introduce a configuration flag to enable or disable automatic magic link sign-in from the clipboard and apply it in the sign-in link flow.
Enhancements: