Fix build with CUDA 13.1 and newer glibc#5
Open
jeroenubbink wants to merge 1 commit into
Open
Conversation
nvcc's crt/math_functions.h declares rsqrt/rsqrtf without noexcept, which conflicts with glibc >= 2.39's C23 rsqrt declaration (pulled in via the _GNU_SOURCE that g++ defines by default), causing a hard compile error. Compile GPURummage.cu with -Xcompiler -U_GNU_SOURCE to avoid the conflict. Also make CUDA and CCAP overridable (?=) instead of hardcoded, and default CUDA to /usr/local/cuda so the Makefile isn't pinned to one toolkit version. Verified: builds cleanly against CUDA 13.1 and successfully mines matching npub addresses on an RTX 5070 Ti (CCAP=120). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvcc's crt/math_functions.h declares rsqrt/rsqrtf without noexcept, which conflicts with glibc >= 2.39's C23 rsqrt declaration (pulled in via the _GNU_SOURCE that g++ defines by default), causing a hard compile error. Compile GPURummage.cu with -Xcompiler -U_GNU_SOURCE to avoid the conflict.
Also make CUDA and CCAP overridable (?=) instead of hardcoded, and default CUDA to /usr/local/cuda so the Makefile isn't pinned to one toolkit version.
Verified: builds cleanly against CUDA 13.1 and successfully mines matching npub addresses on an RTX 5070 Ti (CCAP=120).
Disclaimer: this is 100% videcoded and tested only against CUDA 13.1 and glibc 2.39, please do regression tests on older versions before merging.